Integrate Caliper With Prometheus #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklincoln
requested review from
feihujiang,
jiangyaoguo,
liam-grace and
panyu4
as code owners
Merged
nklincoln
force-pushed
the
prometheus-monitor
branch
4 times, most recently
from
4eebdf2 to
1924f6a
Compare
aklenik
requested changes
Sep 30, 2019
packages/caliper-core/lib/prometheus/prometheus-query-client.js
Outdated
Show resolved
Hide resolved
packages/caliper-core/lib/prometheus/prometheus-query-client.js
Outdated
Show resolved
Hide resolved
aklenik
added
PR/change requested
nklincoln
force-pushed
the
prometheus-monitor
branch
from
1924f6a to
c104851
Compare
|
@aklenik - thanks for the review, I've made the suggested edits, in particular modified the manner in which queries are made to prevent overwriting of parameters - happy to do the same in the |
|
This pull request introduces 1 alert and fixes 2 when merging c104851 into 3f9293a - view on LGTM.com new alerts:
fixed alerts:
|
nklincoln
force-pushed
the
prometheus-monitor
branch
from
c104851 to
e16ce20
Compare
|
This pull request introduces 1 alert and fixes 2 when merging e16ce20 into 3f9293a - view on LGTM.com new alerts:
fixed alerts:
|
nklincoln
force-pushed
the
prometheus-monitor
branch
from
e16ce20 to
adead3e
Compare
|
This pull request fixes 2 alerts when merging adead3e into 3f9293a - view on LGTM.com fixed alerts:
|
- modify local client to conditionally push to a prometheus push gateway - modify returned results to include start/end times of client test - add new prometheus monitor - tidy existing Docker monitor - remove demo.js and move to a test observer class - add test observer interface - add prometheus based and null test observer - rename monitor methods/variables to make them related to what the method/variable is used for - delete zoo related items - modify report builder and report template to enable generic results to be itemised Signed-off-by: [email protected] <[email protected]>
nklincoln
force-pushed
the
prometheus-monitor
branch
from
adead3e to
fea49fd
Compare
|
This pull request fixes 2 alerts when merging fea49fd into 3f9293a - view on LGTM.com fixed alerts:
|
aklenik
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big set of changes here to enable:
Changes include:
Signed-off-by: [email protected] [email protected]